src/commands/workflow/status.ts (1)

44-57: Double getAvailableChanges call when --change is omitted and changes exist.

When options.change is undefined and available.length > 0, getAvailableChanges(projectRoot) is called at line 45, then called again inside validateChangeExists at line 57 (which always calls it when changeName is undefined). Two readdir round-trips for the same path in the same request.

♻️ Proposed fix — pass the already-resolved list to `validateChangeExists`

One approach: short-circuit entirely once you have available, skipping the second validateChangeExists call in the no---change branch.

-    if (!options.change) {
-      const available = await getAvailableChanges(projectRoot);
-      if (available.length === 0) {
-        spinner.stop();
-        if (options.json) {
-          console.log(JSON.stringify({ changes: [], message: 'No active changes.' }, null, 2));
-          return;
-        }
-        console.log('No active changes. Create one with: openspec new change <name>');
-        return;
-      }
-    }
-
-    const changeName = await validateChangeExists(options.change, projectRoot);
+    let changeName: string;
+    if (!options.change) {
+      const available = await getAvailableChanges(projectRoot);
+      if (available.length === 0) {
+        spinner.stop();
+        if (options.json) {
+          console.log(JSON.stringify({ changes: [], message: 'No active changes.' }, null, 2));
+          return;
+        }
+        console.log('No active changes. Create one with: openspec new change <name>');
+        return;
+      }
+      // Changes exist but --change not provided — replicate the validateChangeExists error path
+      spinner.stop();
+      throw new Error(
+        `Missing required option --change. Available changes:\n  ${available.join('\n  ')}`
+      );
+    } else {
+      changeName = await validateChangeExists(options.change, projectRoot);
+    }

Alternatively, this is low-impact enough that a comment acknowledging the duplicate is sufficient if you prefer to keep validateChangeExists as the single source of truth for that error message.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/commands/workflow/status.ts` around lines 44 - 57, When options.change is
undefined you call getAvailableChanges(projectRoot) and then
validateChangeExists(...) will call getAvailableChanges again; avoid the
duplicate readdir by extending validateChangeExists to accept an optional
precomputed list (e.g., available: string[] | undefined) and use that list if
provided instead of calling getAvailableChanges internally, then call
validateChangeExists(options.change, projectRoot, available) from status.ts when
you already have the available array; update the validateChangeExists signature
and its callers accordingly so the second disk lookup is skipped.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

openspec/changes/graceful-status-no-changes/design.md (1)

37-37: ⚠️ Potential issue | 🟡 Minor

Self-contradictory risk/mitigation sentence — previous review comment not yet addressed.

The risk clause states the extra filesystem read occurs "when no changes exist", while the mitigation in the same sentence says "the extra read only happens when changes do exist." These two halves directly contradict each other and are still present in the current code.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@openspec/changes/graceful-status-no-changes/design.md` at line 37, The
sentence describing the risk/mitigation is self-contradictory: clarify whether
the extra filesystem read happens when no changes exist or only when changes do
exist by updating the sentence in design.md; reference the behavior of
getAvailableChanges, validateChangeExists and statusCommand to state precisely
that statusCommand returns early when no --change is provided and no changes
exist (avoiding validateChangeExists and the second read), so the extra read
only occurs when changes exist (because validateChangeExists will call
getAvailableChanges again); rewrite the line to remove the contradiction and
make the condition for the extra read explicit.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro